Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized kernel specs #1028

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
151528d
Add checking custom kernel specs
AnastasiaSliusar May 6, 2024
f5fb178
Add replacing custom kernel specs
AnastasiaSliusar May 7, 2024
ce0864c
Clear kernel spec variables from kernel.json
AnastasiaSliusar May 10, 2024
d796294
Fix cleanup
AnastasiaSliusar May 14, 2024
4aecf42
Add small fixes for validation and cleanup
AnastasiaSliusar May 16, 2024
49e3b9a
Getting default values and fix updating env
AnastasiaSliusar May 21, 2024
6518491
Fix defining custom env parameters
AnastasiaSliusar May 31, 2024
7c21d47
add logging
AnastasiaSliusar Jun 10, 2024
2e62e53
Fix custom parameters of a kernel
AnastasiaSliusar Jun 12, 2024
f6440a9
Fix restarting a kernel with custom env variable and clean printing v…
AnastasiaSliusar Jun 13, 2024
d25af7d
Merge branch 'main' into parametrizing_kernels
AnastasiaSliusar Jun 13, 2024
8cdac5c
Clean printing
AnastasiaSliusar Jun 13, 2024
1b0c92e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 13, 2024
610f018
Fix updating launch parameters when a new kernel is selected
AnastasiaSliusar Jun 21, 2024
db2b88e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 21, 2024
2d3c923
Fix updating launch parameters when a new kernel is selected
AnastasiaSliusar Jun 21, 2024
4e56a30
Add switching parameter
AnastasiaSliusar Jun 24, 2024
c3ac039
Merge branch 'parametrizing_kernels' of https://github.com/AnastasiaS…
AnastasiaSliusar Jun 24, 2024
6c6d9af
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 24, 2024
e6f68e2
Support replacing env and argv by default parameters
AnastasiaSliusar Jun 25, 2024
47400a4
Resolve and merge conflicts
AnastasiaSliusar Jun 25, 2024
b7fac4a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 25, 2024
85d0829
Update a parameter
AnastasiaSliusar Jun 26, 2024
2267438
Resolving conflicts and merging
AnastasiaSliusar Jun 26, 2024
b044207
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 26, 2024
072da9a
Count kernel variables
AnastasiaSliusar Jul 1, 2024
562a3ea
resolving conflicts
AnastasiaSliusar Jul 1, 2024
b646dc1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 1, 2024
7620d38
Update filtering kernels spec
AnastasiaSliusar Jul 2, 2024
a747ee5
resolving conflicts
AnastasiaSliusar Jul 2, 2024
b6f2406
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 2, 2024
3444a5e
Fix checking default values,setup is_secure flag for a kernel spec file
AnastasiaSliusar Jul 4, 2024
622945f
resolving conflicts
AnastasiaSliusar Jul 4, 2024
3e29e21
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 4, 2024
a55983b
Fix defining when a kernel is insecure
AnastasiaSliusar Jul 4, 2024
3ed3db7
resolving conflicts
AnastasiaSliusar Jul 4, 2024
4e93a12
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 4, 2024
ec2f5e7
Fix filtering kernel spec files
AnastasiaSliusar Jul 5, 2024
1c38f12
resolving conflicts
AnastasiaSliusar Jul 5, 2024
5e8bc79
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 5, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
pre-commit-ci[bot] committed Jun 24, 2024
commit 6c6d9af5c766b670be99d4817ed2520e1f628c3e
6 changes: 3 additions & 3 deletions jupyter_client/kernelspec.py
Original file line number Diff line number Diff line change
@@ -231,8 +231,8 @@ def find_kernel_specs(self) -> dict[str, str]:
def allow_parameterized_kernels(self, isParameterizedKernel):
self.isParameterizedKernel = isParameterizedKernel

def _checkParameterizedKernel(self, kspec:KernelSpec)->KernelSpec:
print('kspec')
def _checkParameterizedKernel(self, kspec: KernelSpec) -> KernelSpec:
print("kspec")
print(kspec)
if not self.isParameterizedKernel:
return kspec
@@ -257,7 +257,7 @@ def _get_kernel_spec_by_name(self, kernel_name: str, resource_dir: str) -> Kerne

if not KPF.instance(parent=self.parent).is_provisioner_available(kspec):
raise NoSuchKernel(kernel_name)

kspec = self._checkParameterizedKernel(kspec)

return kspec