-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Python 3.9 → 3.10 #1711
Bump Python 3.9 → 3.10 #1711
Conversation
I think we have a test, that checks python version. |
And, because of our current build system, it's technically impossible to fix this test. |
Ah, ok. I'm finally back from traveling, so hopefully I can manage to wrap my head around #1703. I'd really like to understand all the clever stuff you're doing there! 😄 |
Wow, the test seems to pass. It shouldn’t 😂 |
So is it testing with 3.10 on base and 3.9 on all the other images? I checked the scipy image and it looks like it. So the passing test doesn't mean much anyways, right? But I could test it locally? |
@maresb I fixed this test in master. Please, merge it and it should fail now :) |
@mathbunnyru ok, good, now it's failing as expected. |
@maresb this is just a joke 😂 |
Ooh, very tempting! 😂 Honestly this weekend is unfortunately looking bleak for me accomplishing any fun work. I'm on the road next week, and I have a lot to prepare. I'll see if I can download it and have a look for when I'm offline... |
No pressure here, @maresb :) |
Ah, and I should be clear, I have not tested this myself, so there could be some package further down the chain which is incompatible with 3.10. (But since it's been over ½ year, I think most reputable packages should have adapted by now.) |
That's a good point. That's why our current CI builds something strange, then tests it, then incorrectly tags it, and done. |
Oh, that's great to know! I'm glad that On the other hand, the |
INFO test_python:test_python.py:16 Checking that python version is lower than 3.10 Is this one of our tests? |
I open #1714 where I have changed the test next python version. I did't run on my github, soo I have open it her. |
This will work now, but I will have to rebuild many times, waiting each time for the workflow to complete, to actually update all the images. |
The test we have for python version is not checking the exact match to the expected python version, so the tests should pass. |
Describe your changes
Bump Python 3.9 → 3.10
Issue ticket if applicable
Closes #1688
Checklist (especially for first-time contributors)