Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCAG and ARIA intro #126

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Add WCAG and ARIA intro #126

merged 6 commits into from
Jun 28, 2023

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Apr 25, 2023

This PR is part of #125

It revamps the useful resources by adding a section with an intro to WAI-ARIA and WCAG guidelines.


📚 Documentation preview 📚: https://jupyter-accessibility--126.org.readthedocs.build/en/126/

Copy link
Contributor

@isabela-pf isabela-pf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this document @steff456! It was much needed. I've mostly reviewed for accuracy or adding information where we've learned the hard way that we need to be careful (like the ARIA section).

I tried to add as many comments as possible as suggestions for clarity, but please feel free to take the review and make changes without the suggestions if you see another way you'd like to integrate it into the document. There are good bones here, and it made it easy for me to review.

I do not know how to change the title of this document, but I think Useful Jupyter Accessibility Resources might be worth updating since the things listed here are no longer Jupyter-specific.

Let me know if you have any questions!

docs/resources/useful-resources.md Show resolved Hide resolved
docs/resources/useful-resources.md Outdated Show resolved Hide resolved
docs/resources/useful-resources.md Show resolved Hide resolved
docs/resources/useful-resources.md Outdated Show resolved Hide resolved
docs/resources/useful-resources.md Outdated Show resolved Hide resolved
docs/resources/useful-resources.md Show resolved Hide resolved
docs/resources/useful-resources.md Outdated Show resolved Hide resolved
steff456 and others added 2 commits June 13, 2023 12:13
Co-authored-by: Stephannie Jimenez Gacha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation 📖 Accessible user documentation PR: needs review 👀 This PR is completed and someone needs to have a look type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants