Skip to content

Conversation

@IsabelParedes
Copy link
Member

No description provided.

@IsabelParedes IsabelParedes marked this pull request as ready for review January 15, 2025 12:11
@IsabelParedes IsabelParedes merged commit 8cf478b into jupyter-xeus:main Jan 15, 2025
4 checks passed
@IsabelParedes IsabelParedes deleted the emsdk branch January 15, 2025 12:46
- https://repo.mamba.pm/conda-forge
dependencies:
# Host dependencies
- emscripten-abi==3.1.45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @IsabelParedes @martinRenou

I'm kinda confused here. When I try to get this on macos, I see this

(xeus-cpp-wasm-build) anutosh491@Anutoshs-MacBook-Air build % micromamba install emscripten_emscripten-wasm32==3.1.45 -c https://repo.mamba.pm/emscripten-forge
https://repo.mamba.pm/emscripten-forge/osx-arm64    ??.?MB @  ??.?MB/s  1.5s
https://repo.mamba.pm/emscripten-forge/noarch        2.9kB @   1.3kB/s  2.1s
conda-forge/osx-arm64                               13.9MB @   1.6MB/s  8.5s
conda-forge/noarch                                  18.6MB @   2.1MB/s  8.9s

error    libmamba Could not solve for environment specs
    The following package could not be installed
    └─ emscripten_emscripten-wasm32 ==3.1.45 does not exist (perhaps a typo or a missing channel).
critical libmamba Could not solve for environment specs

Does this mean our CI only works because we use ubuntu

- name: Github-page
os: ubuntu-24.04
emsdk_ver: "3.1.45"

I wanted to extrapolate this idea to xeus-cpp but then we already have emscripten based CI for macos :(
So my question here is if it even makes sense to have so much CI for the lite builds ?

image

If not why ? (asking cause its been there since quite some time and not sure I should get rid of all the osx ones ... rather the osx ones build much quicker than the ubuntu ones)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I would probably not bother with so much CI for the emscripten build. Probably just the ubuntu host is enough?

It seems there is only a recipe for linux in https://beta.mamba.pm/channels/emscripten-forge/packages/emscripten_emscripten-wasm32. We could also probably update the recipe on emscripten-forge to provide emscripten_emscripten-wasm32 on more platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants