Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting argparse <3.1 #522

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

anutosh491
Copy link
Contributor

Fixes #503

@JohanMabille
Copy link
Member

Why an upper pin on 3.1 instead of 4.0? is cpp-argparse known for breaking API on minor releases?

@anutosh491
Copy link
Contributor Author

Why an upper pin on 3.1 instead of 4.0? is cpp-argparse known for breaking API on minor releases?

Ahh yes, correct the upper pin isn't required !

@JohanMabille JohanMabille merged commit 93d61b9 into jupyter-xeus:main Apr 16, 2024
3 checks passed
@anutosh491 anutosh491 deleted the argparse3.0 branch April 16, 2024 09:10
@anutosh491 anutosh491 mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make && make install error while using cpp-argparse 3.0
2 participants