Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the use of _active_widgets in Widget.close_all() #3173

Merged
merged 3 commits into from
Apr 1, 2021
Merged

Fix the use of _active_widgets in Widget.close_all() #3173

merged 3 commits into from
Apr 1, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 26, 2021 •
edited
Loading

This was spotted while rebasing #2765, and is a follow-up to #3122.

image

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch jtpio/ipywidgets/close-all

@jtpio jtpio added this to the 8.0 milestone Mar 26, 2021
@jtpio jtpio marked this pull request as ready for review March 26, 2021 17:21
ianhi
ianhi approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@ianhi ianhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ianhi ianhi merged commit c9afb4b into jupyter-widgets:master Apr 1, 2021
@jtpio jtpio deleted the close-all branch April 1, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhi ianhi ianhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpio @ianhi