-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual regression testing using Galata #3172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Looks great, thanks @mbektasbbg for this! |
@@ -0,0 +1,16 @@ | |||
{ | |||
"name": "ipywidgets-ui-tests", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering whether this new package should be added to the existing lerna
packages? Then we might be able to do without ui-tests/package-lock.json
and keep dependencies in a top-level yarn.lock
.
Or is it better to keep the ui-tests
package a bit more separated from the rest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtpio good point. Initially I tried adding as dependency to top level package.json. I had some build issues then since rest of the project is using chai
for unit testing and that was causing name clashes with jest
that Galata uses (names like it
, test
, expect
). Also, having a separate ui-tests
directory & package decouples things nicely. Only the developers that add UI tests need to install the dependencies (which include browser binaries) and UI tests can work with different jupyterlab versions than ipywidgets is dependent on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add some documentation to guide on adding new UI test cases, building and testing locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, there can indeed be some clashes (also since galata is built for a specific version of lab).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(mbektas#4 demonstrates detecting visual regression caused by change to widget label rendering)
@ellisonbg @blink1073 @afshin FYI, this is the first integration of Galata in a Jupyter project! More to come.