perf: use class_traits with a cache to speed up creation of widgets #3020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results for creating a button `widgets.Button()` ------------------------------------------------ benchmark: 1 tests ----------------------------------------------- Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations ------------------------------------------------------------------------------------------------------------------- test_performance_create 2.8579 36.1314 3.3029 2.0412 3.0983 0.2583 1;22 302.7645 266 1 ------------------------------------------------------------------------------------------------------------------- After this PR, in combination with ipython/traitlets#639 ------------------------------------------------ benchmark: 1 tests ----------------------------------------------- Name (time in ms) Min Max Mean StdDev Median IQR Outliers OPS Rounds Iterations ------------------------------------------------------------------------------------------------------------------- test_performance_create 2.0695 62.7899 2.9496 3.6363 2.3238 0.8066 2;27 339.0254 290 1 ------------------------------------------------------------------------------------------------------------------- Which is a 30% performance increase.
|
Note, without the traitlets PR this result is: |
rmorshea
reviewed
Dec 6, 2020
| @@ -547,6 +548,13 @@ def add_traits(self, **traits): | |||
| self.keys.append(name) | |||
| self.send_state(name) | |||
|
|
|||
| @classmethod | |||
| @functools.lru_cache(None) | |||
There was a problem hiding this comment.
I feel like an unlimited cache size is a bit dangerous. Maybe it's not in practice though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results for creating a button
widgets.Button()After this PR, in combination with ipython/traitlets#639
Which is a 30% performance increase.
Note that
.class_traitsis the same as.traitsbut is a classmethod, so that we can cache on a class level. Note that add_trait will create a new class, so will play nice with the cache. This is tested in case this changes.