Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jp_ws_fetch: passthrough kwargs to websocket_connect #78

Merged
merged 1 commit into from
Apr 3, 2024
Merged

jp_ws_fetch: passthrough kwargs to websocket_connect #78

merged 1 commit into from
Apr 3, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Mar 14, 2024

allows setting things like subprotocols

@minrk
jp_ws_fetch: passthrough kwargs to websocket_connect
007836b 
allows setting things like subprotocols
@minrk minrk added the enhancement New feature or request label Mar 14, 2024
blink1073
blink1073 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c0a675a into jupyter-server:main Apr 3, 2024
21 of 23 checks passed
@minrk minrk deleted the passthough-websocket branch April 3, 2024 12:49
@blink1073 blink1073 mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minrk @blink1073