Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client plugin and echo kernel #20

Merged
merged 10 commits into from
Nov 27, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 27, 2022

Fixes #18

@blink1073 blink1073 added the enhancement New feature or request label Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Base: 86.45% // Head: 94.70% // Increases project coverage by +8.25% 🎉

Coverage data is based on head (1a7df48) compared to base (9b58f0b).
Patch coverage: 94.89% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   86.45%   94.70%   +8.25%     
==========================================
  Files           5       10       +5     
  Lines         310      453     +143     
  Branches       69        0      -69     
==========================================
+ Hits          268      429     +161     
- Misses         20       24       +4     
+ Partials       22        0      -22     
Impacted Files Coverage Δ
pytest_jupyter/jupyter_client.py 92.85% <92.85%> (ø)
pytest_jupyter/echo_kernel.py 94.73% <94.73%> (ø)
pytest_jupyter/__init__.py 100.00% <100.00%> (ø)
pytest_jupyter/jupyter_server.py 92.85% <100.00%> (+8.06%) ⬆️
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_jupyter_client.py 100.00% <100.00%> (ø)
tests/test_jupyter_server.py 100.00% <100.00%> (ø)
pytest_jupyter/_version.py
tests/test_jupyter_core.py 100.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 enabled auto-merge (squash) November 27, 2022 04:46
@blink1073 blink1073 merged commit 8d6d0cb into jupyter-server:main Nov 27, 2022
@blink1073 blink1073 deleted the add-client-plugin branch November 27, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add client fixtures
1 participant