[WIP] Issue 29: HTTP API Support #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can add GET, POST, PUT, and DELETE method from notebok. Can access request body in cells (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
Fixed encoding issue with args parsing. Added scotch notebook example. (c) Copyright IBM Corp. 2015
(c) Copyright IBM Corp. 2015
| help='Designates that the kernel gateway will serve APIs from this notebook (KG_API env var)' | ||
| ) | ||
| def _api_default(self): | ||
| return os.getenv(self.api_env) |
There was a problem hiding this comment.
Probably want this returning a default string representing the "notebook kernel API + jupyter protocol over websocket" option. Why: we've got one protocol+api, you guys are working on a second (notebook defined API over HTTP), and there might be more coming down the pipe (e.g., see #17). Best to plan for extensibility here.
Make the help print the available valid options. You can get it to show the default too: see the others where I set the value + used the default method.
(c) Copyright IBM Corp. 2015
…rror handling from kernel Add more noteboks with examples. Add Scotch demo API. (c) Copyright IBM Corp. 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(c) Copyright IBM Corp. 2015