Add db_journal_mode trait to FileIdManager classes #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability for operators/admins to set the journal mode of the underlying SQLite database. Because FileID Manager classes have different characteristics, the default
db_journal_mode
for theArbitraryFileIdManager
will beDELETE
(which is the SQLite default), while the default forLocalFileIdManager
will beWAL
since its more performant from a multi-threaded standpoint - although not supported on NFS-mounted filesystems. Because the default FileID Manager isArbitraryFileIdManager
, environments configured on NFS-mounted filesystems should now work out-of-the-box.Operators can use the
db_journal_mode
trait to set it to any valid value depending on their needs. The set of valid values are {"DELETE", "TRUNCATE", "PERSIST", "MEMORY", "WAL", "OFF"}.The informational message indicating tables and indices will be created is also extended to include the journal mode setting:
Resolves: #60