Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use UUIDs for default file ID manager implementations #30

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dlqqq
Copy link
Collaborator

@dlqqq dlqqq commented Oct 26, 2022

Closes #3.

@dlqqq dlqqq added the enhancement New feature or request label Oct 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Base: 79.39% // Head: 79.68% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (c1b3411) compared to base (5f1741a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   79.39%   79.68%   +0.28%     
==========================================
  Files           5        5              
  Lines         495      502       +7     
  Branches       68       68              
==========================================
+ Hits          393      400       +7     
  Misses         80       80              
  Partials       22       22              
Impacted Files Coverage Δ
jupyter_server_fileid/manager.py 88.71% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kevin-bates
Copy link
Member

Sorry, I'm confused. I thought @davidbrochart's PR to allow arbitrary Contents Managers had defined an ABC class named AbstractFileIdManager? But now see that is not the case. I believe there are several issues with this. Rather than attempt to reference source code that is not part of this PR, I've submitted a (late) review on #24 (where the applicable lines are still part of the PR).

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dlqqq - these changes look good relative to the conversion to UUID. Most of my comments are a carryover from the late review on #24 and assumptions made about what arbitrary fileId managers might need. I apologize for those being a bit off-topic.

Since it's clear that those are potential changes in a separate PR, I'm approving these changes relative to the conversion to UUID. We can follow up regarding my comments here or not.

Thanks for the ping.

jupyter_server_fileid/manager.py Show resolved Hide resolved
jupyter_server_fileid/manager.py Show resolved Hide resolved
jupyter_server_fileid/manager.py Show resolved Hide resolved
@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 27, 2022

@kevin-bates Thank you for your comments! I'm just going to go ahead and merge this for now since none of them pertain to the UUID implementation. We can keep discussing in this PR and #24 of course.

@dlqqq dlqqq merged commit f9fbdde into jupyter-server:main Oct 27, 2022
@dlqqq dlqqq deleted the uuid branch October 27, 2022 01:03
@dlqqq
Copy link
Collaborator Author

dlqqq commented Oct 27, 2022

@kevin-bates Actually, let's just keep all discussion local to #24 for cleanliness. I'll copy my responses over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use UUIDs for primary keys
3 participants