Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with client 8 updates #992

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 25, 2022

Testing against client PR. I removed the client 8 pins after the builds passed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Base: 71.43% // Head: 71.26% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (4711ebe) compared to base (507c697).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x     #992      +/-   ##
==========================================
- Coverage   71.43%   71.26%   -0.18%     
==========================================
  Files          62       62              
  Lines        7738     7739       +1     
  Branches     1286     1286              
==========================================
- Hits         5528     5515      -13     
- Misses       1821     1831      +10     
- Partials      389      393       +4     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 57.68% <100.00%> (-0.97%) ⬇️
jupyter_server/services/contents/filemanager.py 70.60% <0.00%> (-1.61%) ⬇️
jupyter_server/serverapp.py 65.33% <0.00%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blink1073 blink1073 marked this pull request as draft September 25, 2022 01:45
@blink1073 blink1073 marked this pull request as ready for review September 25, 2022 23:24
@blink1073 blink1073 merged commit 27bc44c into jupyter-server:1.x Sep 26, 2022
@blink1073 blink1073 deleted the client-8-support branch September 26, 2022 17:59
@blink1073 blink1073 changed the title Test with client 8 updates Test with client 8 updates Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants