Correct content-type headers #965
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Gateway client should set content-type to application/json when issuing POST requests with json-encoded body
epignot
force-pushed
the
fix-content-type
branch
from
e6e2234
to
e7a9541
Compare
|
Congrats on your first merged pull request in this project! 🎉 |
|
@epignot - I apologize for the dropped change - thank you for resubmitting! @blink1073 - thank you for the approval and merge! |
(cherry-picked from commit 15310fd)
(cherry-picked from commit 15310fd)
|
No worries @kevin-bates ! Thank you @blink1073 ! I submitted #966 to backport this to |
Co-authored-by: Emmanuel Pignot <[email protected]>
This workaround is no longer needed since this fix: jupyter-server/jupyter_server#965
* remove old workaround for jupyterlab This workaround is no longer needed since this fix: jupyter-server/jupyter_server#965 * add workaround for JupyterLab v4+ JupyterLab v4 and Notebook v7 use a new ws subprotocol our backend doesn't support yet. `GatewayWebSocketConnection.kernel_ws_protocol` option forces to use the legacy websocket subprotocol * update VSCode extension doc The VSCode extension layout changed a bit, so I added an updated image and updated the connection process. I also fixed some troubleshooting tips --------- Co-authored-by: Emmanuel Pignot <[email protected]>
GatewayKernelManager does not send the correct
Content-Typeheader when issuing POST requests for kernel creation.This was initially fixed in PR : #471
But got reverted when gateway manager was refactored, in this commit : 062b5f4