Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 v5 compat #941

Merged
merged 3 commits into from
Aug 4, 2022
Merged

Fix flake8 v5 compat #941

merged 3 commits into from
Aug 4, 2022

Conversation

blink1073
Copy link
Contributor

The repo is incompatible with flake v5 and appears to be under-maintained.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #941 (4fb3f73) into main (a8bf3f6) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   72.30%   72.22%   -0.08%     
==========================================
  Files          65       65              
  Lines        8001     8001              
  Branches     1336     1333       -3     
==========================================
- Hits         5785     5779       -6     
- Misses       1810     1813       +3     
- Partials      406      409       +3     
Impacted Files Coverage Δ
jupyter_server/services/contents/filemanager.py 70.61% <0.00%> (-0.79%) ⬇️
jupyter_server/serverapp.py 65.48% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@blink1073 blink1073 changed the title Remove usage of flake8-logging-format Fix flake8 v5 compat Aug 4, 2022
@blink1073 blink1073 merged commit ba7ac85 into main Aug 4, 2022
@blink1073 blink1073 deleted the blink1073-patch-3 branch August 4, 2022 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants