Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TrailingSlashHandler #91

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Fix TrailingSlashHandler #91

merged 1 commit into from
Sep 23, 2019

Conversation

vidartf
Copy link
Member

@vidartf vidartf commented Sep 20, 2019

Fixes #81.

rolweber
rolweber approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@rolweber rolweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rolweber rolweber merged commit 5c32e6d into jupyter-server:master Sep 23, 2019
@rolweber
Copy link
Contributor

Thanks!

@vidartf vidartf deleted the fix-trailing-slash branch September 23, 2019 06:11
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
@Zsailer
Log events that link kernels to client sessions (jupyter-server#91)
fcbdd29 
* add custom session manager and begin logging events

* add handler for debug mode that prints to standout

* add a test for telemetry

* add event before session starts

* add nbclassic as an explicit extension

* uncomment tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolweber rolweber rolweber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TrailingSlashHandler redirect loop
2 participants
@vidartf @rolweber