Make it easier for extensions to customize the ServerApp #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. a custom ServerApp subclass, or inserting steps prior to `initialize`
blink1073
reviewed
Jun 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 72.28% 72.29% +0.01%
==========================================
Files 65 65
Lines 7974 7978 +4
Branches 1332 1332
==========================================
+ Hits 5764 5768 +4
Misses 1804 1804
Partials 406 406
Continue to review full report at Codecov.
|
blink1073
approved these changes
Jun 16, 2022
Zsailer
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. a custom ServerApp subclass, or inserting steps prior to
initialize.I've been looking into how to enable JupyterHub's "disable user config" feature, and this isn't really feasible because ServerApp is instantiated and fully configured inside the
initialize_server, so I'd have to override the wholeinitialize_servermethod.Being able to insert a custom ServerApp subclass and/or modify it should give JupyterHub the hook we need to implement this.