Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show import error when faiing to load an extension #878

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jun 16, 2022

import error may not be on the top-level module, it could deeper, e.g. during load another import fails, which is currently hidden

import error may not be on the top-level module, it could deeper,
e.g. during load
@minrk minrk force-pushed the debug-extension-importerror branch from 907794a to f3a2020 Compare June 16, 2022 12:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #878 (f3a2020) into main (d901415) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
+ Coverage   70.25%   70.33%   +0.07%     
==========================================
  Files          65       65              
  Lines        7683     7683              
  Branches     1284     1284              
==========================================
+ Hits         5398     5404       +6     
+ Misses       1897     1889       -8     
- Partials      388      390       +2     
Impacted Files Coverage Δ
jupyter_server/extension/manager.py 92.75% <100.00%> (ø)
jupyter_server/services/kernels/kernelmanager.py 80.25% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d901415...f3a2020. Read the comment docs.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@blink1073 blink1073 merged commit 7b5815e into jupyter-server:main Jun 16, 2022
@blink1073
Copy link
Contributor

@meeseeksdev please backport to 1.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyter_server that referenced this pull request Jun 16, 2022
blink1073 pushed a commit that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants