Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #874 on branch 1.x (Fix gateway kernel shutdown) #875

Merged

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #874: Fix gateway kernel shutdown

@lumberbot-app lumberbot-app bot added the bug label Jun 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #875 (36ce714) into 1.x (7bbc200) will increase coverage by 0.09%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##              1.x     #875      +/-   ##
==========================================
+ Coverage   70.33%   70.42%   +0.09%     
==========================================
  Files          62       62              
  Lines        7652     7655       +3     
  Branches     1269     1270       +1     
==========================================
+ Hits         5382     5391       +9     
+ Misses       1886     1880       -6     
  Partials      384      384              
Impacted Files Coverage Δ
jupyter_server/gateway/managers.py 60.10% <61.53%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bbc200...36ce714. Read the comment docs.

@blink1073 blink1073 merged commit 1aa1250 into jupyter-server:1.x Jun 15, 2022
@kevin-bates
Copy link
Member

Thank you @blink1073!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants