Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hatch build plugin #845

Merged
merged 8 commits into from
May 28, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented May 14, 2022

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2022

Codecov Report

Merging #845 (222efd6) into main (d5f2ad9) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #845      +/-   ##
==========================================
- Coverage   70.12%   70.06%   -0.07%     
==========================================
  Files          65       65              
  Lines        7622     7622              
  Branches     1268     1268              
==========================================
- Hits         5345     5340       -5     
- Misses       1895     1898       +3     
- Partials      382      384       +2     
Impacted Files Coverage Δ
jupyter_server/utils.py 60.89% <0.00%> (-1.49%) ⬇️
jupyter_server/base/handlers.py 63.61% <0.00%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f2ad9...222efd6. Read the comment docs.

@blink1073 blink1073 mentioned this pull request May 16, 2022
@blink1073 blink1073 changed the title Switch to hatch backend Switch to hatch build plugin May 17, 2022
@blink1073
Copy link
Contributor Author

This is ready for discussion at tomorrow's meeting.

@blink1073
Copy link
Contributor Author

@blink1073 blink1073 marked this pull request as ready for review May 26, 2022 21:47
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh nice @blink1073. I didn't know this existed.

@blink1073
Copy link
Contributor Author

Thanks @willingc! The conversion is still a WIP, based on needs in jupyterlab/jupyterlab#12606 and jupyter/notebook#6425.

@blink1073 blink1073 merged commit 061d846 into jupyter-server:main May 28, 2022
@blink1073 blink1073 deleted the use-hatch branch May 28, 2022 00:48
@blink1073
Copy link
Contributor Author

Once we have a solution and migration script/guide for extension authors, I'll write a blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants