pass extension_name to only extension app handlers #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Aug 3, 2019
There was a problem hiding this comment.
Thanks @Zsailer. I stepped through the code yesterday, after conveying the issue to you, and this change makes perfect sense and accounts for the multiple tracebacks (one for each handler that isn't an ExtensionHandler).
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that was breaking jupyter/notebook#4653.
Passes the
extension_namearg to only handlers that subclass the ExtensionHandler class. This bug was breaking custom static filehandlers in the notebook extension app.