Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Server Tests on Windows #519

Merged
merged 1 commit into from
May 18, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented May 18, 2021

Windows Terminal tests were disabled in #201, but can now be enabled based on improvements in pywinpty 1.1. Also fixes test failure introduced in #504

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2021

Codecov Report

Merging #519 (3216dbe) into master (6bf5914) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   76.99%   77.03%   +0.04%     
==========================================
  Files         107      107              
  Lines        9511     9511              
  Branches     1032     1031       -1     
==========================================
+ Hits         7323     7327       +4     
+ Misses       1815     1813       -2     
+ Partials      373      371       -2     
Impacted Files Coverage Δ
jupyter_server/services/config/manager.py 100.00% <ø> (ø)
jupyter_server/tests/extension/test_manager.py 100.00% <100.00%> (ø)
jupyter_server/tests/test_terminal.py 98.80% <100.00%> (+2.33%) ⬆️
jupyter_server/services/kernels/kernelmanager.py 80.79% <0.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 284c938...3216dbe. Read the comment docs.

@blink1073 blink1073 added this to the 1.8 milestone May 18, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 83a49c8 into jupyter-server:master May 18, 2021
@jtpio jtpio deleted the windows-terminal-tests branch May 18, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants