Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtensionPoint: return True on successful validate() #503

Merged
merged 2 commits into from
May 3, 2021
Merged

ExtensionPoint: return True on successful validate() #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87298c9
return True on successful ExtensionPoint validation
minrk May 3, 2021
0a86f7c
fail validation if validate returns False
minrk May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jupyter_server/extension/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ def validate(self):
self._get_loader()
except Exception:
return False
else:
return True

def link(self, serverapp):
"""Link the extension to a Jupyter ServerApp object.
Expand Down
3 changes: 2 additions & 1 deletion jupyter_server/extension/serverextension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,8 @@ def list_server_extensions(self):
GREEN_ENABLED if enabled else RED_DISABLED))
try:
self.log.info(" - Validating {}...".format(name))
extension.validate()
if not extension.validate():
raise ValueError("validation failed")
version = extension.version
self.log.info(
" {} {} {}".format(name, version, GREEN_OK)
Expand Down
2 changes: 2 additions & 0 deletions jupyter_server/tests/extension/test_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def test_extension_point_api():
assert app is not None
assert callable(e.load)
assert callable(e.link)
assert e.validate()


def test_extension_point_metadata_error():
Expand Down Expand Up @@ -59,6 +60,7 @@ def test_extension_package_api():
assert hasattr(e, "extension_points")
assert len(e.extension_points) == len(metadata_list)
assert app.name in e.extension_points
assert e.validate()


def test_extension_package_notfound_error():
Expand Down