Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Styling to the HTML Pages #452

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Add Styling to the HTML Pages #452

merged 1 commit into from
Mar 22, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Mar 22, 2021

Fixes #271

Copies more the templates and styling from notebook, including the use of bootstrap.

Including bootstrap adds an npm build step and brings the package from 275kB to 405kB.

1

2

3

4

@codecov-io
Copy link

codecov-io commented Mar 22, 2021

Codecov Report

Merging #452 (b96ed8e) into master (abaa8cd) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   77.78%   77.77%   -0.02%     
==========================================
  Files         106      106              
  Lines        9103     9103              
  Branches      971      971              
==========================================
- Hits         7081     7080       -1     
  Misses       1674     1674              
- Partials      348      349       +1     
Impacted Files Coverage Δ
jupyter_server/services/kernels/handlers.py 58.24% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abaa8cd...b96ed8e. Read the comment docs.

@blink1073 blink1073 added this to the 1.6 milestone Mar 22, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 74801f4 into jupyter-server:master Mar 22, 2021
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let's style the password/token page.
3 participants