More complex handling of open_browser from extension applications #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default value open_browser in extension applications slightly.
Before this was set to
True
always. That means, even ifServerApp.open_browser=False
, a browser was still opened. Now, the extension first checks if the server'sopen_browser
trait was configured. If so, it uses this configured value; otherwise, it defaults toTrue
.In the case where both the starting extension application and the underlying server application receive a configuration value for
open_browser
, the extension application wins as you'd expect.This PR also drops the
--pyargs
config frompytest.ini
because it prevents you from running individual tests (always runs the whole test suite). Instead, it is advised to runpytest <path to tests>
. Updated the README and GA workflows to reflect this change.