Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable notebook ContentsManager in jupyter_server #392

Merged
merged 3 commits into from
Jan 29, 2021
Merged

Enable notebook ContentsManager in jupyter_server #392

merged 3 commits into from
Jan 29, 2021

Conversation

afshin
Copy link
Contributor

@afshin afshin commented Jan 21, 2021

jupyter_server's contents_manager_class doesn't accept subclasses of notebook's ContentsManager. While this is the desired behavior for the future of jupyter_server, during this transition phase from notebook to jupyter_server, we should allow notebook's ContentManagers to pass through.

This PR relaxes the contents_manager_class to allow these managers. To do this, new traittypes are defined and used that check the incoming types/instances against a list of classes.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. It makes sense and the warning message is sufficiently detailed - thanks.

jupyter_server/serverapp.py Outdated Show resolved Hide resolved
jupyter_server/serverapp.py Show resolved Hide resolved
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zsailer Zsailer merged commit 5dc20a3 into jupyter-server:master Jan 29, 2021
Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
* move cookie_secret_file to a non-persistent location, since it should be updated on any server restart

* Bump to 0.20.2
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
Enable notebook ContentsManager in jupyter_server
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants