Apply missing ensure_async to root session handler methods #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 69.28% 69.30% +0.01%
==========================================
Files 56 56
Lines 6128 6128
Branches 798 798
==========================================
+ Hits 4246 4247 +1
Misses 1616 1616
+ Partials 266 265 -1
Continue to review full report at Codecov.
|
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
… page in reconnect dialogue (jupyter-server#386) * more debugging logs; add a button to ignore heartbeat dialogue and direct users to spark page * add details about spark to reconnect dialog
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Apply missing ensure_async to root session handler methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While migrating Enterprise Gateway from using notebook to jupyter_server, I ran across a couple of methods in the session handler that needed
ensure_asyncwrappers around their calls to the session manager.