Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register websocket handler from same module as kernel handlers #1249

Merged

Conversation

kevin-bates
Copy link
Member

During the 2.x refactor of kernel websocket management, the file from which the websocket handler is registered changed. The presents problems for applications that extend or leverage services and handlers from Jupyter Server (like Kernel Gateway and Enterprise Gateway, and perhaps other third-party applications). As a result, those applications must account for this this file which presents problems for supporting both JupyterServer 1.x and 2.x.

This change moves the websocket handler registration back to the services/kernels/handlers.py file so that "extending applications" don't require changes in their registration code to use JS 2.

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.41 ⚠️

Comparison is base (702c248) 80.39% compared to head (48fa8a9) 78.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   80.39%   78.99%   -1.41%     
==========================================
  Files          68       68              
  Lines        8264     8263       -1     
  Branches     1600     1600              
==========================================
- Hits         6644     6527     -117     
- Misses       1198     1311     +113     
- Partials      422      425       +3     
Impacted Files Coverage Δ
jupyter_server/serverapp.py 72.59% <ø> (-8.14%) ⬇️
jupyter_server/services/kernels/websocket.py 79.59% <ø> (-0.81%) ⬇️
jupyter_server/services/kernels/handlers.py 89.04% <100.00%> (+0.15%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 6ad8006 into jupyter-server:main Mar 27, 2023
@Zsailer
Copy link
Member

Zsailer commented Mar 29, 2023

Oops, sorry about that Kevin! Thank you for fixing this.

@kevin-bates kevin-bates deleted the register-ws-handler-w-others branch March 29, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants