Fix calculation of schema location

[lresende]

Move away of using lstrip to manipulate the base URI while calculating schema location

Fixes #1238

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.13 ⚠️

Comparison is base (e582e55) 80.39% compared to head (54d30ed) 80.27%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
- Coverage   80.39%   80.27%   -0.13%     
==========================================
  Files          68       68              
  Lines        8263     8263              
  Branches     1600     1600              
==========================================
- Hits         6643     6633      -10     
- Misses       1198     1206       +8     
- Partials      422      424       +2     

Impacted Files	Coverage Δ
jupyter_server/serverapp.py	80.63% <100.00%> (-0.09%)	⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lresende]

Hehe, so, the trailing slash is needed to properly calculate the relative location of the schema. I tried to add it to the definition of the path const but it seemed to break some test cases, I can play more with this later today in case you guys don't like the current approach.

[Zsailer]

Nah, I think this is good to go. Thank you @lresende. :)

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️