Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation warning #1148

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Update deprecation warning #1148

merged 3 commits into from
Dec 22, 2022

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Dec 22, 2022

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 80.05% // Head: 80.01% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (1bdf131) compared to base (7e26967).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   80.05%   80.01%   -0.04%     
==========================================
  Files          68       68              
  Lines        8062     8062              
  Branches     1600     1600              
==========================================
- Hits         6454     6451       -3     
- Misses       1184     1187       +3     
  Partials      424      424              
Impacted Files Coverage Δ
jupyter_server/utils.py 85.11% <ø> (ø)
...ter_server/services/kernels/connection/channels.py 58.71% <0.00%> (-1.11%) ⬇️
jupyter_server/serverapp.py 80.38% <0.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

jupyter_server/utils.py Outdated Show resolved Hide resolved
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 enabled auto-merge (squash) December 22, 2022 14:46
@blink1073 blink1073 merged commit af5ba66 into jupyter-server:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants