[Gateway] Remove redundant list kernels request during session poll #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 80.03% // Head: 80.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1112 +/- ##
==========================================
+ Coverage 80.03% 80.06% +0.03%
==========================================
Files 68 68
Lines 8013 8011 -2
Branches 1586 1586
==========================================
+ Hits 6413 6414 +1
+ Misses 1179 1177 -2
+ Partials 421 420 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@blink1073 - I'm fine deferring this merge until post 2.0, unless there's an issue that warrants another RC cycle. Once merged, it would be awesome if we could backport this to 1.x. Thanks. |
blink1073
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lab services issues
/api/kernelsand/api/sessionsrequests every 10 seconds on behalf of itsKernelManagerandSessionManagerinstances, respectively. When a gateway server is configured, the/api/kernelsrequest is forwarded to the gateway server, while the/api/sessionsrequest only needs to ensure the kernel model in its list of sessions is still valid (i.e., not culled) - which leads to an additional (but specific)/api/kernels/<kernel_id>request.In highly latent and multi-tenant installations (in which a single gateway is servicing multiple clients) each of these requests adds up. This pull request eliminates the
/api/kernels/<kernel_id>request performed on behalf of the client's/api/sessionsrequest by treating the set of kernel models maintained via the/api/kernelsrequest as the truth. Since the/api/kernelsrequest will detect kernels culled on the gateway server and update its list accordingly, we can use the kernel_id's absence in the list as an indicator it has been culled, triggering the session's deletion from the session table. The net effect of this is that the periodic (and constant)/api/kernelsrequests are reduced by 50%.