Import ensure_async from jupyter_core

[davidbrochart]

Needs jupyter/jupyter_core#315.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (96bcdbb) to head (8f3d9dd).
Report is 265 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
+ Coverage   79.99%   80.02%   +0.03%     
==========================================
  Files          68       68              
  Lines        8021     8011      -10     
  Branches     1588     1586       -2     
==========================================
- Hits         6416     6411       -5     
+ Misses       1183     1179       -4     
+ Partials      422      421       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[davidbrochart]

Not sure the test failures are related.
How do we ensure jupyter-core v.5.0.0 is not installed?

[blink1073]

I think jupyter_core>=4.12,!=~5.0

[davidbrochart]

Should we just pin jupyter_core>=4.12,<5, and when we switch to v5 we'll pin jupyter_core>=5.1?

[blink1073]

Should we just pin jupyter_core>=4.12,<5, and when we switch to v5 we'll pin jupyter_core>=5.1?

I'd rather not pin, since we want folks to try core 5.x and its new features.

[blink1073]

I'll have to update the min versions script in maintainer tools though to handle more complex cases like this...

[bollwyvl]

Working on the conda-forge package... what exactly is intended by the jupyter_core pin?

[davidbrochart]

jupyter-core v4.12 and v5.1 have the ensure_async and run_sync common functions that are used in jupyter-server, jupyter-client and nbclient. Each one was previously reimplementing the logic separately.

[bollwyvl]

ok, cheers. Going to ship the less-ambiguous:

jupyter_core >=4.12,!=5.0.0,<6

[davidbrochart]

Sounds good, but maybe !=5.0.* instead of !=5.0.0?
And I thought we were not pinning upper bounds any more?

[bollwyvl]

great, i'll remove the top pin.

[bollwyvl]

Here's the line in question:
conda-forge/jupyter_server-feedstock#106 (review)

[transaxon]

Looks as if this may have caused an error under Ubuntu 20.04 running under WSL2

$ ImportError: cannot import name 'ensure_async' from 'jupyter_core.utils'

[davidbrochart]

What version of jupyter_core do you have?

[transaxon]

mjw@TRANSAXON-SEROTONIN:~$ jupyter --version
Selected Jupyter core packages...
IPython : 8.4.0
ipykernel : 6.13.0
ipywidgets : 8.0.2
jupyter_client : 7.3.1
jupyter_core : 4.10.0
jupyter_server : 2.0.1
jupyterlab : not installed
nbclient : not installed
nbconvert : not installed
nbformat : 5.7.0
notebook : 6.0.3
qtconsole : 5.3.0
traitlets : 5.2.2

[transaxon]

It's not at all clear to me why it thinks jupyterlab nbclient and nbconvert aren't installed

[davidbrochart]

jupyter-server 2.0.1 requires jupyter_core>=4.12, try creating a new environment.