Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base handler tests #1090

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Nov 23, 2022

Caught a bug in AuthenticatedFileHandler.get. When .head is called, it calls .get with include_body=False.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.34%. Comparing base (bd236f1) to head (81f4613).
Report is 275 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   78.64%   79.34%   +0.70%     
==========================================
  Files          68       68              
  Lines        8301     8294       -7     
  Branches     1650     1649       -1     
==========================================
+ Hits         6528     6581      +53     
+ Misses       1347     1285      -62     
- Partials      426      428       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 enabled auto-merge (squash) November 23, 2022 22:35
@blink1073 blink1073 merged commit a763da3 into jupyter-server:main Nov 23, 2022
@blink1073 blink1073 deleted the handlers-coverage branch November 23, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant