Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 2 specific code after NB port #109

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

kevin-bates
Copy link
Member

One of the commits ported from Notebook reverted previous changes to drop support for python 2.

This change is the only known issue stemming from the batched port exercise.

Closes: #96

Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zsailer Zsailer merged commit ccc64d7 into jupyter-server:master Sep 27, 2019
@kevin-bates kevin-bates deleted the final-cleanup branch September 27, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up after Notebook syncing
2 participants