Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass kernel environment to cwd_for_path method #1046

Merged

Conversation

divyansshhh
Copy link
Contributor

Solved #1045

@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.10%. Comparing base (213e25c) to head (c023243).
Report is 315 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   73.10%   73.10%           
=======================================
  Files          64       64           
  Lines        8274     8274           
  Branches     1643     1643           
=======================================
  Hits         6049     6049           
  Misses       1816     1816           
  Partials      409      409           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyansshhh - these changes look good. Could you please update your branch and we'll get this merged?

@blink1073
Copy link
Contributor

I updated the branch

@blink1073 blink1073 enabled auto-merge (squash) November 3, 2022 14:41
@blink1073 blink1073 merged commit 27c30ad into jupyter-server:main Nov 3, 2022
divyansshhh added a commit to divyansshhh/jupyter_server that referenced this pull request Nov 7, 2022
blink1073 added a commit that referenced this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants