Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use admin github token for releaser #1025

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

blink1073
Copy link
Contributor

We need to rely on the user permissions check instead of using the user GITHUB_TOKEN directly, because even as an admin I was unable to push commits directly to the main branch without turning off the branch protection rules.

@blink1073 blink1073 enabled auto-merge (squash) October 10, 2022 21:53
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.52%. Comparing base (8811e96) to head (6e2ba73).
Report is 329 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   72.65%   72.52%   -0.14%     
==========================================
  Files          64       64              
  Lines        8251     8251              
  Branches     1257     1257              
==========================================
- Hits         5995     5984      -11     
- Misses       1839     1851      +12     
+ Partials      417      416       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 merged commit 7dee3ab into jupyter-server:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants