Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback new file type to file for contents put #1013

Conversation

a3626a
Copy link
Contributor

@a3626a a3626a commented Oct 6, 2022

This changes allow new file type can be saved by contents put request.
I think this should be fixed during #895.

Related Issue:
#884

@welcome
Copy link

welcome bot commented Oct 6, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (4604ce0) to head (3e69993).
Report is 334 commits behind head on main.

Files with missing lines Patch % Lines
jupyter_server/services/contents/handlers.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   72.59%   72.51%   -0.08%     
==========================================
  Files          64       64              
  Lines        8249     8251       +2     
  Branches     1256     1257       +1     
==========================================
- Hits         5988     5983       -5     
- Misses       1847     1852       +5     
- Partials      414      416       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blink1073 blink1073 added the bug label Oct 6, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit ba92f31 into jupyter-server:main Oct 6, 2022
@welcome
Copy link

welcome bot commented Oct 6, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants