Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the concurrent futures in an asyncio future #1000

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

blink1073
Copy link
Contributor

Follow up to #988

@blink1073 blink1073 added the bug label Sep 27, 2022
@blink1073
Copy link
Contributor Author

Ugh, this still won't work:

Deprecated since version 3.10: Deprecation warning is emitted if future is not a Future-like object and loop is not specified and there is no running event loop.

Okay, so we need to detect if there is a running loop and create the appropriate future type.

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.38%. Comparing base (e61ba81) to head (0ce6e79).
Report is 37 commits behind head on 1.x.

Files with missing lines Patch % Lines
jupyter_server/services/kernels/handlers.py 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1000      +/-   ##
==========================================
+ Coverage   71.27%   71.38%   +0.11%     
==========================================
  Files          62       62              
  Lines        7742     7748       +6     
  Branches     1283     1286       +3     
==========================================
+ Hits         5518     5531      +13     
+ Misses       1831     1827       -4     
+ Partials      393      390       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW - with these changes, I no longer see the issue stemming from #988 (comment).

Thanks @blink1073!

@blink1073 blink1073 merged commit 690d2f4 into jupyter-server:1.x Sep 27, 2022
@blink1073 blink1073 deleted the use-asyncio-future branch September 27, 2022 20:13
blink1073 added a commit to blink1073/jupyter_server that referenced this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants