Add jinja template support to pod-name config via environment variable #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-bates
reviewed
Feb 19, 2024
docs/source/users/kernel-envs.md
Outdated
| @@ -75,7 +75,9 @@ There are several supported `KERNEL_` variables that the Enterprise Gateway serv | |||
| cases, Enterprise Gateway will honor that value. However, when provided, | |||
| it is the user's responsibility that KERNEL_POD_NAME is unique relative to | |||
| any pods in the target namespace. In addition, the pod must NOT exist - | |||
| unlike the case if KERNEL_NAMESPACE is provided. | |||
| unlike the case if KERNEL_NAMESPACE is provided. The KERNEL_POD_NAME can | |||
| also be provided as a jinja2 template (e.g "{{ kernel_id }}") string which | |||
There was a problem hiding this comment.
I think it would be good to show a practical example rather than just kernel-id. Could you please add a string prefix like "my-kernel" or something?
kevin-bates
added
enhancement
kubernetes
gateway-provisioners
lresende
force-pushed
the
apple-pod-name-template
branch
from
f7abefa to
2a213b6
Compare
for more information, see https://pre-commit.ci
|
@kevin-bates I added a little more complex jinja template, hopefully gives a better picture to users. As for gateway-provisioners, please let me know where to... |
kevin-bates
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.