Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readthedocs build configuration #1367

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

lresende
Copy link
Member

No description provided.

@lresende lresende force-pushed the apple-fix-readthedocs branch 2 times, most recently from 2ca7230 to 9464246 Compare February 18, 2024 21:24
@lresende lresende force-pushed the apple-fix-readthedocs branch from 9464246 to 6c26e62 Compare February 18, 2024 21:29
@lresende lresende requested a review from kevin-bates February 18, 2024 21:34
@kevin-bates
Copy link
Member

Thanks for dealing with this @lresende. Could you please add a comment to the file why the conda block is commented out?

@lresende
Copy link
Member Author

lresende commented Feb 19, 2024

@kevin-bates brought back the conda support, needed a different config to make it work again (based on mamba)

@lresende lresende requested review from kevin-bates and removed request for kevin-bates February 19, 2024 01:51
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lresende!

@lresende lresende merged commit 1de1784 into jupyter-server:main Feb 19, 2024
14 checks passed
@lresende lresende deleted the apple-fix-readthedocs branch February 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants