Dump Kubernetes YAML/CRD on kernel startup fails #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A submitted kernel can fail due to malformation of YAML/CRD contents and in this case, dumping the files in the log can help with problem determination.
for more information, see https://pre-commit.ci
kevin-bates
added
kubernetes
remote-provisioners
gateway-provisioners
kevin-bates
reviewed
Feb 5, 2023
| @@ -225,6 +225,8 @@ def launch_kubernetes_kernel( # noqa | |||
| f"kernel launch terminating!" | |||
| ) | |||
| else: | |||
| print("ERROR processing Kubernetes yaml file - kernel launch terminating!") | |||
| print(k8s_yaml) | |||
There was a problem hiding this comment.
Hi @lresende. Do you have an example of what the print output looks like? I suspect this will output the entire yaml on a single line and I wonder, since this would be used primarily for troubleshooting, if using pretty print pprint would be more helpful?
There was a problem hiding this comment.
It does in a pretty way, at least on the spark operator:
apiVersion: "sparkoperator.k8s.io/v1beta2"
kind: SparkApplication
metadata:
name: xxxx-dafe8b37-9579-4cda-a8ab-d9f33a6dadba
labels:
proxyUser: "xxxxx"
spec:
serviceAccountName: xxx
mode: cluster
type: Python
kevin-bates
approved these changes
Feb 5, 2023
kevin-bates
approved these changes
Feb 5, 2023
kevin-bates
added
gateway-provisioners-ported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A submitted kernel can fail due to the malformation of
YAML/CRD contents and in this case, dumping the
files in the log can help with problem determination.