Flow configured envs from client to kernel pod #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…success" This reverts commit d63e9a8.
|
@lresende, @rahul26goyal - could I please get a review from either of you? @blair-anson - if you'd like to provide a review (or anyone else) - that would be much appreciated! Thank you. |
kiersten-stokes
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
This LGTM! Confirmed that envs prefixed with KUBECONFIG or KUBERNETES_SERVICE are flowed to the pod (and others are not, unless specified separately in the YAML) by running some notebooks that print out assigned env values. Overwrite of relevant YAML env values with current env values is also working as expected.
|
Going ahead with the merge - thank you for your review @kiersten-stokes. |
This was referenced Dec 13, 2022
kevin-bates
added
gateway-provisioners
kevin-bates
added
gateway-provisioners-ported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #1160, it became apparent that the flow of env variables from the client to the kernel pods is not working for
KubernetesProcessProxy. Only a fixed set ofKERNEL_-prefixed variables were transferred to the pod, along with system-defined values for the kernel launcher parameters. This pull request ensures that envs configured to flow to the kernel pod do flow.Previously, because k8s relies on its own envs, we unconditionally included all EG-configured envs as well, even though those also never found their way into the kernel pod. This PR only copies EG envs prefixed with
KUBECONFIGorKUBERNETES_SERVICErather than the entire EG environment.