Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install pre-commit as part of the lint make task #1111

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Install pre-commit as part of the lint make task #1111

merged 4 commits into from
Jun 13, 2022

Conversation

lresende
Copy link
Member

@lresende lresende commented Jun 13, 2022 •
edited
Loading

The build wasn't working in clean environments
unless you had manually installed pre-commit dependency.

@lresende lresende requested a review from kevin-bates June 13, 2022 03:25
kevin-bates
kevin-bates reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lresende - I left a couple of comments/questions.

@kevin-bates
Copy link
Member

Thanks for the updates. Was update-demo-base.sh accidentally included? Seems like a local helper script.

kevin-bates
kevin-bates approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @lresende

@kevin-bates kevin-bates merged commit 7358612 into jupyter-server:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-bates kevin-bates kevin-bates approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lresende @kevin-bates