-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reintroduce conda env setup and docs #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @bloomsa - thank you. I just had a couple of comments. Thanks for you help here.
Co-authored-by: Kevin Bates <[email protected]>
Co-authored-by: Kevin Bates <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @bloomsa - thank you!
I and others are seeing an issue with this PR and I apologize for merging this too soon (sigh). I don't really know how to resolve the following and I'm also wondering why @bloomsa didn't encounter this. Here are the results:
@blink1073 - we suspect this change to |
It might be that it is installing from |
Trying Related, I see that Also, it may be worth pointing out that
|
Thanks @blink1073 and @kiersten-stokes. I'm afk for the weekend but, assuming I'm following things, sounds like the jinja dependency requires updating (along with the relative directory adjustment). Kiersten, if that works for you would you mind opening a pull request? |
Sorry about this!! 😢 I must not have fully cleaned my env up before trying to rebuild it.. Thanks for fixing it up @kiersten-stokes |
Per #1098, I am reintroducing some of the conda env pieces to assist with locally running EG and with debugging using an IDE. I specifically brought the targets for making and activating the conda environment but did not add that back to all of the other steps as it remains unnecessary for them.
I also updated the Contributor docs to reflect the additional step that can be used to aid local development
Resolves: #1098