Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jupyter serverextension enable --py jupyter_lsp to install instructions #257

Closed
wants to merge 2 commits into from

Conversation

krassowski
Copy link
Member

References

See final comments in #250. I think that we talked about it earlier, but it turns out to be needed for quite a few users, so let's have it here. Not sure if this should be commented by default and marked as optional, or just kept uncommented - I do not see any harm in running this command again if extension is already enabled.

@krassowski krassowski closed this Apr 28, 2020
@krassowski krassowski reopened this Apr 28, 2020
@@ -108,6 +108,7 @@ Use of a python `virtualenv` or a conda env is also recommended.

```bash
pip install jupyter-lsp
jupyter serverextension enable --py jupyter_lsp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this gets into the whole configuration ball of wax, which the jupyter_notebook_config.d approach is trying to avoid. The bothersome thing is in both of our CI excursions, we install from the whl distributions, which is what most people will pull, and yet this still persists. But, yeah, i guess if it ain't workin'...

As written, this is going to add or change a config file in ~/.jupyter (or wherever the heck it goes in windows), and make it try to load for every jupyter notebook derived thing you load, at which point it will create errors. So especially if you have folk that sudo everything if it doesn't work the first time, you're going to get stuff owned by root in your ~, which rapidly leads to more madness.

If anything, i guess we'd want to suggest:

jupyter serverextension enable --py --sys-prefix jupyter_lsp

and/or a pre/post-flight of:

jupyter serverextension list

@thakkarparth007
Copy link

@krassowski , please merge this. I would've saved two day's efforts if I'd known this earlier :)

@krassowski
Copy link
Member Author

It hopefully should not be a problem anymore with new jupyter_server required for 3.0.

@krassowski krassowski closed this Jan 9, 2021
@krassowski krassowski deleted the krassowski-add-enable branch August 11, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants