feat: support ipywidgets>8 by passing tuples to dropdown instead of dict#797
Merged
feat: support ipywidgets>8 by passing tuples to dropdown instead of dict#797
Conversation
|
FYI, ipywidgets 8.0.2 adds back in support for dicts since now dicts are ordered, though it isn't advertised in the docs: jupyter-widgets/ipywidgets#3557 |
This is noted in #769 (comment) too. However, I think these changes look good to me, and an improvement. |
Collaborator
Author
|
Thanks for reviewing @jasongrout! I saw that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #769
Relates to jupyter-widgets/ipywidgets#2679
ipywidgets dropped supported for map types in 8.0.0 because drop downs should be ordered. This PR passes an ordered list of tuples to all of the references to
Dropdowninstead of a dict.Note:
dictsupport was re-added in jupyter-widgets/ipywidgets#3557, but still think it makes sense to move to an ordered list of tuplesChecklist
blackCHANGELOG.mdfileREADME.mdfile