Add new constructor for Histogram and Summary taking rvalue ref of parameters #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sjanel
commented
Mar 28, 2022
•
sjanel
commented
- Set default values to object fields in header file to limit code duplication as well.
- Mark constructors taking only one parameter as explicit
sjanel
force-pushed
the
chore/addmoveconstructor_histogram_summary
branch
3 times, most recently
from
8e69ef1 to
6b8f225
Compare
gjasny
reviewed
Apr 3, 2022
gjasny
requested changes
Apr 3, 2022
sjanel
force-pushed
the
chore/addmoveconstructor_histogram_summary
branch
2 times, most recently
from
ae8bbe7 to
56b37e8
Compare
sjanel
force-pushed
the
chore/addmoveconstructor_histogram_summary
branch
from
56b37e8 to
450718f
Compare
gjasny
approved these changes
Apr 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.