Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quantile object has const members : difficult to use within a vector<Quantile> #425

Closed
FabienCarmagnac opened this issue Dec 11, 2020 · 0 comments · Fixed by #493
Closed

Quantile object has const members : difficult to use within a vector<Quantile> #425

FabienCarmagnac opened this issue Dec 11, 2020 · 0 comments · Fixed by #493

Comments

@FabienCarmagnac
Copy link

FabienCarmagnac commented Dec 11, 2020 •
edited
Loading

In v0.10.0 : Quantile object has const members (not copiable), so not really usable inside a vector.

It is not possible to push_back Quantile's into a std::vector. We have to use another container.
If some internal reason needs it, I suggest to initialize the summary quantile set passing begin+end iterator.
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
b738880 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
@jupp0r jupp0r mentioned this issue May 14, 2021
Merged
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
588fa73 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
06e3d81 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
00238ae 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
69d52da 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
jupp0r pushed a commit that referenced this issue May 14, 2021
Make summary quantiles non-const
a287e45 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
jupp0r added a commit that referenced this issue May 14, 2021
@jupp0r
Make summary quantiles non-const (#493)
5522e6f 
This change removes an unnecessary API constraint that makes it
harder to dynamically construct quantile configurations for summaries.

Fixes #425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make summary quantiles non-const jupp0r/prometheus-cpp
1 participant
@FabienCarmagnac