feat(divider): create new component #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
…reate-component-divider
gabrielduete
requested review from
a team,
dyhalmeida,
mauriciomutte,
luiz-ortega and
jowjow22
and removed request for
a team
MayaraRMA
previously approved these changes
Jan 30, 2025
tassioFront
reviewed
Jan 30, 2025
dyhalmeida
previously approved these changes
Jan 30, 2025
gabrielduete
dismissed stale reviews from dyhalmeida and MayaraRMA
via
a261a86
tassioFront
previously approved these changes
Jan 30, 2025
gabrielduete
requested review from
tassioFront,
felipefialho,
dyhalmeida and
MayaraRMA
|
felipefialho
approved these changes
Jan 30, 2025
luiz-ortega
approved these changes
Jan 31, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
This pull request introduces a new
AtomDividercomponent to the codebase, along with its associated styles, tests, and storybook configurations for different frameworks (React, Vue, and Web Components). The most important changes include the addition of theAtomDividercomponent, its SCSS styling, unit tests, and storybook stories.New Component Addition:
packages/core/src/components/divider/divider.tsx: Added theAtomDividercomponent with atypeprop that can be either 'up' or 'down'.packages/core/src/components/divider/divider.scss: Added styles for theAtomDividercomponent, including conditional styling based on thetypeprop.Testing:
packages/core/src/components/divider/divider.spec.ts: Added unit tests for theAtomDividercomponent to ensure it renders correctly with both 'up' and 'down' types.Storybook Configuration:
packages/core/src/components/divider/stories/divider.args.ts: Defined storybook arguments for theAtomDividercomponent, including documentation and control options for thetypeprop.packages/core/src/components/divider/stories/divider.core.stories.tsx: Added storybook stories for theAtomDividercomponent in the web components framework.packages/core/src/components/divider/stories/divider.react.stories.tsx: Added storybook stories for theAtomDividercomponent in the React framework.packages/core/src/components/divider/stories/divider.vue.stories.tsx: Added storybook stories for theAtomDividercomponent in the Vue framework.Closes: #100
What impacts?
Core components
Reversal plan
Revert pr #692
Evidences
Gravacao.de.Tela.2025-01-30.as.13.38.22.mov